feat: set provider id earlier #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
force-pushed
the
set-provider-id-earlier
branch
from
7ad4064 to
6818d56
Compare
Callisto13
force-pushed
the
set-provider-id-earlier
branch
from
6818d56 to
1624d9a
Compare
Callisto13
changed the title
This returns the microvm in the Create response so that we can use details for subsequent actions, eg status checks and getting the UUID.
Instead we can just switch on the state immediately (at that point it will be the default `pending`) and update the cluster conditions before requeueing.
At the old location the ID was not persisted before the state switch, meaning that we would sometimes (in almost all cases) exit and requeue before it was set. This lead to dupe mvms being created on multiple hosts.
Callisto13
force-pushed
the
set-provider-id-earlier
branch
from
1624d9a to
9387801
Compare
jmickey
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: set the provider ID earlier
At the old location the ID was not persisted before the state switch,
meaning that we would sometimes (in almost all cases) exit and requeue
before it was set. This lead to dupe mvms being created on multiple
hosts.
Closes #111
feat: do not requeue after a create
Instead we can just switch on the state immediately (at that point it
will be the default
pending) and update the cluster conditions beforerequeueing.
feat: Return mvm object from service.Create
This returns the microvm in the Create response so that we can use
details for subsequent actions, eg status checks and getting the UUID.
Closes #113