Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linter config to match flintlock #31

Closed
richardcase opened this issue Nov 19, 2021 · 0 comments · Fixed by #115
Closed

Update linter config to match flintlock #31

richardcase opened this issue Nov 19, 2021 · 0 comments · Fixed by #115
Assignees
@yitsushi
Labels
good first issue Good for newcomers help wanted Requires help from contributors to get done kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@richardcase
Copy link
Member

Describe the solution you'd like:
Update the linter configuration so its in line with flintlock:

https://github.com/weaveworks/flintlock/blob/main/.golangci.yml

So enable all linters and explicitly disable deprecated linters.

Why do you want this feature:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@richardcase richardcase added good first issue Good for newcomers help wanted Requires help from contributors to get done kind/feature New feature or request labels Nov 19, 2021
@richardcase richardcase added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 2, 2021
@Callisto13 Callisto13 self-assigned this Dec 6, 2021
@Callisto13 Callisto13 removed their assignment Dec 17, 2021
@yitsushi yitsushi self-assigned this Jan 14, 2022
@yitsushi yitsushi mentioned this issue Jan 14, 2022
Closed
4 tasks
@yitsushi yitsushi mentioned this issue Jan 25, 2022
Merged
4 tasks
yitsushi added a commit that referenced this issue Jan 28, 2022
@yitsushi
refactor: update linter to match with flintlock and fix related issues
321aadb 
fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yitsushi yitsushi

Labels
good first issue Good for newcomers help wanted Requires help from contributors to get done kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
3 participants
@yitsushi @richardcase @Callisto13