-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solc updated to 0.8.20 (ETH-1254) #246
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 72 72
Lines 1694 1694
Branches 229 229
=======================================
Hits 1614 1614
Misses 26 26
Partials 54 54 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, i found a single file that hadn't been updated, but i pushed a fix for that.
I also like how the natspecs are now better after this compiler update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
The solidity version of the current contracts is set to
0.8.10
. Currently the latest version of solidity is0.8.23
.There are numerous fixes and enhancements that have been shipped till now to the
solc
. As a best practice it is suggested to use as latest as possiblesolc
. This PR updates the solc version to0.8.20
.Notice
Pull Request Type