Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solc updated to 0.8.20 (ETH-1254) #246

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Solc updated to 0.8.20 (ETH-1254) #246

merged 7 commits into from
Nov 30, 2023

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented Nov 29, 2023

Description

The solidity version of the current contracts is set to 0.8.10. Currently the latest version of solidity is 0.8.23.
There are numerous fixes and enhancements that have been shipped till now to the solc. As a best practice it is suggested to use as latest as possible solc. This PR updates the solc version to 0.8.20.

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

@iamsahu iamsahu self-assigned this Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c762b0) 95.27% compared to head (25a58c2) 95.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          72       72           
  Lines        1694     1694           
  Branches      229      229           
=======================================
  Hits         1614     1614           
  Misses         26       26           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamsahu iamsahu marked this pull request as ready for review November 29, 2023 14:04
@iamsahu iamsahu requested a review from cebidhem as a code owner November 29, 2023 14:04
@iamsahu iamsahu requested a review from mischat November 29, 2023 14:04
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, i found a single file that hadn't been updated, but i pushed a fix for that.

I also like how the natspecs are now better after this compiler update.

:shipit:

@iamsahu iamsahu changed the title Solc updated to 0.8.20 Solc updated to 0.8.20 (ETH-1254) Nov 30, 2023
Copy link
Member

@cebidhem cebidhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@iamsahu iamsahu merged commit 9a9920a into main Nov 30, 2023
18 checks passed
@iamsahu iamsahu deleted the feat/solc-0.8.20 branch November 30, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants