Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E] kubeadm provider refactoring #2956

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[E2E] kubeadm provider refactoring #2956

merged 1 commit into from
Feb 21, 2025

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Feb 20, 2025 •
edited
Loading

Description

This PR replace the infrastructure name from "cluster-api" to "kubeconfig" and implement the download of clusterctl.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the ci Changes to CI configuration files or scripts label Feb 20, 2025
@cheina97 cheina97 changed the title [Kubeadm] refactoring [E2E] refactoring Feb 20, 2025
@cheina97 cheina97 changed the title [E2E] refactoring [E2E] kubeadm provider refactoring Feb 20, 2025
@cheina97
Copy link
Member Author

/test

2 similar comments
@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 marked this pull request as ready for review February 20, 2025 16:48
fra98
fra98 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@fra98 fra98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the e2e targets that use ../liqoctl/.. in the Makefile

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Feb 21, 2025
@adamjensenbot adamjensenbot merged commit 7605eed into master Feb 21, 2025
16 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Feb 21, 2025
@adamjensenbot adamjensenbot deleted the frc/cirefactor branch February 21, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

Assignees
No one assigned
Labels
ci Changes to CI configuration files or scripts size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @fra98