Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: added evaluation priority flags #2313

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Jan 31, 2024

Description

This PR adds to the docs the order in which flags are evaluated when installing Liqo through liqoctl

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 requested a review from aleoli February 5, 2024 09:47
@fra98
Copy link
Member Author

fra98 commented Feb 5, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/docs-priority-flags branch from 5c6d1a2 to 912ae50 Compare February 5, 2024 10:09
@fra98
Copy link
Member Author

fra98 commented Feb 5, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/docs-priority-flags branch from 912ae50 to c552758 Compare February 5, 2024 11:39
@fra98 fra98 force-pushed the frt/docs-priority-flags branch from c552758 to 955b77e Compare February 5, 2024 13:42
@fra98
Copy link
Member Author

fra98 commented Feb 5, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Feb 5, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Feb 5, 2024
@adamjensenbot adamjensenbot merged commit 63c0488 into liqotech:master Feb 5, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants