Merge remote-tracking branch 'upstream/develop' into develop

* upstream/develop:
  make use of phpunit 6.5 for PHP 5.6.
  fix failing test for group removal confirmation message.
  Add props for CMB2#1208
  Move the remove_confirm option to the example functions and leave default empty (to not break back-compat)
  Oops, fix typeof yoda check
  Fix removal confirmation in tests
  Simplify removal confirmation check
  Update typeof checks to use yoda
  make remove confirmation a bit more succinct
  Cannot use empty on an operation on older versions of php
  see CMB2#529 - improvements as per PR review:
  see CMB2#529 - fix tests with a default confirm value in DOM equal to no.
  fix CMB2#529 - Add confirm dialog to group Remove button.
  Add props for CMB2#1206
  Add php tests npm script
  Add grunt watch npm script
  Add props for CMB2#1204
  Ignore composer vendor dir
  fix CMB2#1205 - Package.json: fix the need of global (old) grunt.
  fix 1023 - Update PHPUnit version in composer.json.
  Add props for CMB2#1200
  Remove superfluous method definitions
  Add develop class suffix to init.php class
  Bump version for hotfix release
  Fix issue when wp.data does not have core/editor. Check it first. Fixes CMB2#1197
  Update version to 2.5.0
  Update changelog
  Make install-wp-tests.sh executable
  Update tests to pass
  Add cmb_init_pickers and cmb_init_code_editors events for allowing just-in-time configuration for pickers/editors
  Make CMB2.getFields/CMB2.getFields more robust, allowing a filter callback, and specifying by field id

.gitignore

@@ -64,6 +64,9 @@ ocular.phar
 # PHPunit config
 phpunit.xml
 
+# Composer
+vendor
+
 # General
 NOTES.md
 apigen/

CHANGELOG.md

@@ -2,13 +2,33 @@
 All notable changes to this project will be documented in this file.
 
 ## Unreleased
+
+### Enhancements
+
+* Updated PHPUnit version in composer.json. Props [@slaFFik](https://github.com/slaFFik) ([#1204](https://github.com/CMB2/CMB2/pull/1204)).
+* Package.json: fix the need of global (old) grunt. Props [@slaFFik](https://github.com/slaFFik) ([#1206](https://github.com/CMB2/CMB2/pull/1206)).
+* Add optional confirmation dialog to group field's Remove button. Example [documented in the example functions file](https://github.com/CMB2/CMB2/blob/12036e2dcdeb5b019e844b814eca154bb0eee791/example-functions.php#L525). Props [@slaFFik](https://github.com/slaFFik) ([#1208](https://github.com/CMB2/CMB2/pull/1208)).
+
+### Bug Fixes
+* Remove superfluous method definitions. Props [@tnorthcutt](https://github.com/tnorthcutt) ([#1200](https://github.com/CMB2/CMB2/pull/1200)).
+
+## [2.5.1 - 2018-12-10](https://github.com/CMB2/CMB2/releases/tag/v2.5.1)
+
+### Bug Fixes
+* Fix issue when the `core/editor` object does not exist (is undefined), causing incompatibility issues with Yoast and likely others. Fixes [#1197](https://github.com/CMB2/CMB2/issues/1197)
+
+## [2.5.0 - 2018-12-08](https://github.com/CMB2/CMB2/releases/tag/v2.5.0)
+
 ### Enhancements
 
 * Repeatable fields are now drag-sortable. Props [@lipemat](https://github.com/lipemat) ([#1142](https://github.com/CMB2/CMB2/pull/1142)).
 * Update the `sv_SE` translation. Props [@edvind](https://github.com/edvind) ([#370](https://github.com/CMB2/CMB2/pull/370)).
 * QA/PHPCS cleanup. Props [@tw2113](https://github.com/tw2113) ([#1179](https://github.com/CMB2/CMB2/pull/1179)).
 * Add optional `'mb_callback_args'` CMB2 box property which allows defining the `$callback_args` passed into `add_meta_box()`. This allows using defining the new [Gutenberg/block-editor compatibility parameters](https://wordpress.org/gutenberg/handbook/extensibility/meta-box/). Fixes [#1191](https://github.com/CMB2/CMB2/issues/1191)
 * Support any type of markup when customizing repeating group row. Props [@lipemat](https://github.com/lipemat) ([#1187](https://github.com/CMB2/CMB2/pull/1187)).
+* Add `cmb_init_pickers` and `cmb_init_code_editors` Javascript events for allowing just-in-time configuration for pickers/editors.
+* Fix field descriptions color contrast ratio for better accessibility. h/t [@rianrietveld](https://github.com/rianrietveld). Fixes [#1193](https://github.com/CMB2/CMB2/issues/1193).
+* Add `CMB2_Field::get_rest_value()` method for sending value through several filters (`'cmb2_get_rest_value'`, `"cmb2_get_rest_value_{$field_type}"`, `"cmb2_get_rest_value_for_{$field_id}"` ) before sending to REST request.
 
 ### Bug Fixes
 

README.md

@@ -28,8 +28,8 @@ require __DIR__ . '/vendor/autoload.php'
 **Homepage:**          [https://cmb2.io](https://cmb2.io)  
 **Tags:**              metaboxes, forms, fields, options, settings  
 **Requires at least:** 3.8.0  
-**Tested up to:**      4.9.6  
-**Stable tag:**        2.4.2  
+**Tested up to:**      5.0.0  
+**Stable tag:**        2.5.1  
 **License:**           GPLv2 or later  
 **License URI:**       [http://www.gnu.org/licenses/gpl-2.0.html](http://www.gnu.org/licenses/gpl-2.0.html)  
 

composer.json

@@ -36,8 +36,11 @@
   "require": {
     "php": ">=7.1.3"
   },
+  "suggest": {
+    "composer/installers": "~1.0"
+  },
   "require-dev": {
-    "phpunit/phpunit": "3.7.*"
+    "phpunit/phpunit": "^6.5"
   },
   "autoload": {
     "files": [