Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #711 #712

Merged
merged 2 commits into from
May 24, 2018
Merged

fix #711 #712

merged 2 commits into from
May 24, 2018

Conversation

JoshKeegan
Copy link
Collaborator

See #711

@JoshKeegan
Copy link
Collaborator Author

I've added a couple more fixes (of the same problem for other params) found by searching the solution for "%.
I opted for putting the comma in the string and letting it be URL encoded in StringExtensions.AddParameterToQuery as I thought it was clearer and made this less likely to happen again.

I've left it as-is in TweetQueryGenerator.GetTweetsQuery because the parameter is added in String.Format, so using %2C there saves an explicit URL encoding call, so it does seem cleaner there. I've added a comment just to make it clear what's happenning.

@linvi linvi self-assigned this May 24, 2018
@linvi linvi added the bug label May 24, 2018
@linvi linvi added this to the Version 4.0 milestone May 24, 2018
@linvi linvi changed the base branch from master to 4.0 May 24, 2018 21:35
@linvi linvi merged commit 3c46d51 into linvi:4.0 May 24, 2018
@linvi
Copy link
Owner

linvi commented May 24, 2018

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants