Skip to content
This repository was archived by the owner on Feb 17, 2023. It is now read-only.

Adds mediaarea repo #3

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

captn3m0
Copy link
Contributor

@captn3m0 captn3m0 commented Mar 27, 2018

Fixes Radarr/Radarr#2668 (comment)

This upgrades mediainfo since the mediainfo package in ubuntu 16.04 is quite old.

  • Had to duplicate the apt-get update because you can't run update against a HTTPS repo without having the transport installed and installing that requires an update.
  • The mediaarea GPG key fingerprint can be verified at https://mediaarea.net/en/Repos

Thanks for maintaining this!

@LinuxServer-CI
Copy link
Contributor

Can an admin please whisper to jenkins to test this PR.

@captn3m0
Copy link
Contributor Author

Another solution might be to install apt-transport-https on the lsiobase/ubuntu:xenial layer.

@sparklyballs
Copy link
Contributor

installing unneeded dependencies in an upstream image used by many more images downstream is not viable for us

also i'd want to see that mediainfo version you're advocating here is compatible with sonarr radarr etc before going with it

nothing here about ubuntu but concerning newer version of mediainfo

https://forums.sonarr.tv/t/mediainfo-library-could-not-be-loaded-libmediainfo-so-0-fedora-26/16923

@galli-leo
Copy link

@sparklyballs Our CI server is running a docker image based on debain and the latest mediainfo passes all tests. So I think this should be fine. Anyways, Sonarr upgraded the windows & osx libraries to mediainfo 17.10 a while ago, so those are guaranteed to work. (Radarr will follow shortly).

@sparklyballs
Copy link
Contributor

@galli-leo old eyes here didn't register the link in the PR text lol

do you know how shortly radarr is likely to be using the newer library ?

cos we have two options here

1 is to update the baseimage github repository now and wait for our jenkins to build a new verison on friday (we don't autobuild new baseimages on pr commit etc) but if we go this method it requires radarr to be ready before the friday refresh

2 if radarr is imminent on the change we can hold off till they're ready and then build the baseimage and do the downstream builds in one hit

@galli-leo
Copy link

@sparklyballs probably in about two weeks, but I think you misunderstood me. This would only be for windows or osx, under linux we always use the library installed by the user. This can be any version. However, if the sonarr team decided to use the latest binaries for windows and osx, it’s safe to assume that the linux ones should be working fine.

In short, it doesn‘t matter when we update our libraries, since we will use the one you provide anyways.

@sparklyballs
Copy link
Contributor

jenkins test this please

@sparklyballs sparklyballs merged commit 9ccc15a into linuxserver-archive:master Mar 27, 2018
@captn3m0 captn3m0 deleted the mediaarea-repo branch March 28, 2018 04:14
@sparklyballs
Copy link
Contributor

sparklyballs commented Apr 2, 2018

@galli-leo it would seem that this has broken linuxserver/docker-sonarr#67

@galli-leo
Copy link

@sparklyballs I just pulled the image and can find the correctly named libmediainfo. Not sure what went wrong on that issue.

@sparklyballs
Copy link
Contributor

there was a missed update to the develop branch as we were hit by the DO block storage downtime

rebuilt to latest dev version and i'll query the user to see if that has resolved it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants