Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run ansible-lint against the collection #156

Closed
wants to merge 9 commits into from

Conversation

richm
Copy link
Collaborator

@richm richm commented May 17, 2023

The latest Ansible repo gating tests run ansible-lint against
the collection format instead of against individual roles.
We have to convert the role to collection format before running
ansible-test.

Role developers can run this locally using
tox -e collection,ansible-lint-collection
See linux-system-roles/tox-lsr#125

ha_cluster - add to python_roles

metrics - fix ansible-lint

Signed-off-by: Rich Megginson [email protected]

The latest Ansible repo gating tests run ansible-lint against
the collection format instead of against individual roles.
We have to convert the role to collection format before running
ansible-test.

Role developers can run this locally using
`tox -e collection,ansible-lint-collection`
See linux-system-roles/tox-lsr#125

ha_cluster - add to python_roles

metrics - fix ansible-lint

Signed-off-by: Rich Megginson <[email protected]>
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b3bbc7f) 74.44% compared to head (3b1da89) 74.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files           1        1           
  Lines         450      450           
=======================================
  Hits          335      335           
  Misses        115      115           
Flag Coverage Δ
sanity ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richm richm closed this Oct 4, 2023
@richm richm deleted the ansible-lint-collection branch October 4, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant