Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile with create-react-app #411

Closed
shantur opened this issue Nov 24, 2019 · 4 comments
Closed

Cannot compile with create-react-app #411

shantur opened this issue Nov 24, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@shantur
Copy link

shantur commented Nov 24, 2019

Due to stringify-object being dependent on get-own-enumerable-property-symbols and target for Node.js instead of browsers ( sindresorhus/stringify-object#49 (comment) )
UglifyJS throws error while compiling this with react

SyntaxError: Unexpected token: operator (>) [./~/get-own-enumerable-property-symbols/lib/index.js:3,0]

Just a thought why not use JSON.stringify instead?

@linuswillner
Copy link
Owner

That shouldn't be in there anymore... Will investigate.

@linuswillner linuswillner added the bug Something isn't working label Nov 24, 2019
@linuswillner linuswillner self-assigned this Nov 24, 2019
@shantur
Copy link
Author

shantur commented Nov 25, 2019

Ignore me false alarm, i just found out CRA version was too low.

@shantur shantur closed this as completed Nov 25, 2019
@linuswillner
Copy link
Owner

linuswillner commented Nov 25, 2019

Don't apologise, because you did point me to an actual legitimate issue here! The string comparison stuff was not meant to be there anymore; it was supposed to have been removed in v3.0.2 due to issues reported in #35. I've removed the leftover stringify-object logic and fixed the comparison issues in v3.0.3, which I just pushed. Thanks for the report!

@shantur
Copy link
Author

shantur commented Nov 25, 2019

Thanks @linuswillner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants