Separated touch and delete #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, the delete command does not really support a time parameter even though the code had support for it - https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L254 Also, found that the expiry parameter is mandatory in touch - https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L324. For these reasons, it makes more sense to use separate functions.
|
just to mention that the function of flush_all should support an optional delay time according to the memcached protocol. I will make a pull request later, i think. |
linsomniac
added a commit
that referenced
this pull request
Apr 16, 2023
Port of erankor's PR #30 to the latest code. In that PR, the "time" argument to delete() is removed because it is not supported by the protocol: https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L330 And touch requires the expiry parameter due to protocol: https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L399
|
Thank you for the PR, I have updated it to match the new code and included it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the delete command does not really support a time parameter
even though the code had support for it -
https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L254
Also, found that the expiry parameter is mandatory in touch -
https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L324.
For these reasons, it makes more sense to use separate functions.
(Note - easier to review this change comparing to the version before my previous pull request -
erankor/python-memcached@794b028...e0ba0fc)