Add add_vpcs and add_placement_groups user grants #1720
Conversation
stvnjacobs
requested review from
ykim-akamai and
yec-akamai
and removed request for
a team
| resource.TestCheckResourceAttr(testUserResName, "global_grants.0.add_stackscripts", "false"), | ||
| resource.TestCheckResourceAttr(testUserResName, "global_grants.0.add_volumes", "false"), | ||
| resource.TestCheckResourceAttr(testUserResName, "global_grants.0.add_vpcs", "false"), |
There was a problem hiding this comment.
This file is what give me the most uncertainty. I confess to not digging to far into how it worked and just chose "false" in both cases.
stvnjacobs
force-pushed
the
feat/user-grants-pg-vpc
branch
2 times, most recently
from
98f08dc to
975aadf
Compare
stvnjacobs
force-pushed
the
feat/user-grants-pg-vpc
branch
2 times, most recently
from
845787c to
a69d4a8
Compare
linodego added support for the `add_vpcs` and `add_placement_group` user grants in v1.44.0 (linode/linodego#622). This patch adds support for these fields in the `linode_user` resource.
stvnjacobs
force-pushed
the
feat/user-grants-pg-vpc
branch
from
a69d4a8 to
bc963d5
Compare
|
Thanks for your contribution! |
|
I am sorry, but I don't think I understand. This patch adds this missing |
|
@stvnjacobs No worries, there are another group for the non-global user grants, like: We can handle them after merging this PR. |
|
@zliang-akamai I believe I have satisfied your request, minus the
I already see someone else added the |
This adds the missing `vpc_grant` and `placement_group_grants` to the user resources and their data sources.
stvnjacobs
force-pushed
the
feat/user-grants-pg-vpc
branch
from
b7490e0 to
673dd2d
Compare
|
Looks good, just one unit test failure in the latest commit |
📝 Description
linodego added support for the
add_vpcsandadd_placement_groupuser grants in v1.44.0 (linode/linodego#622). At the time of writing, terraform-provider-linode is on [email protected]. This patch adds support for these fields in thelinode_userresource.✔️ How to Test
I have run
make, andmake unit-tests, but not run the integration tests. I believe all tests cases were updated, as I followed the same pattern used in other grants.