Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update chart version index for a single chart #1867

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

j-zimnowoda
Copy link
Contributor

@j-zimnowoda j-zimnowoda commented Dec 13, 2024

I noticed that some PRs created by Helm chart bot have more that one dependency version number updated in the Chart.yaml file. Example: https://github.com/linode/apl-core/pull/1863/files#diff-1c892db7344feb10640b6353e7452859ca22f33e57737e167a4cc55d23ba91f2

This PR fixes that issue.

Testing:
In local environment: at ci/.env:

CI_UPDATE_TYPE='minor'
CI_HELM_CHART_NAME_FILTER='[]'
CI_GH_CREATE_PR='false'
CI_GIT_BASELINE_BRANCH='APL-11-1'
CI_GIT_LOCAL_BRANCH_ONLY='true'

then run

src/update-helm-chart-deps.mjs

then

git checkout ci-update-sealed-secrets-to-2.17.0
gd HEAD~1

You should see only one version updated

 dependencies:
   - name: argo-cd
     version: 6.7.3
@@ -60,7 +44,7 @@ dependencies:
     version: 6.11.2
     repository: https://grafana.github.io/helm-charts
   - name: sealed-secrets
-    version: 2.14.1
+    version: 2.17.0
     repository: https://bitnami-labs.github.io/sealed-secrets/
   - name: tekton-pipeline
     version: 1.0.2

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but it works on my machine! ✅

ci/src/update-helm-chart-deps.mjs Outdated Show resolved Hide resolved
@j-zimnowoda j-zimnowoda enabled auto-merge (squash) December 13, 2024 16:09
@j-zimnowoda j-zimnowoda merged commit d636aba into main Dec 16, 2024
5 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-11-1 branch December 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants