feat(policy): check Service port in admission controller #13325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our Gateway API bindings say:
Port specifies the destination port number to use for this resource.
Port is required when the referent is a Kubernetes Service. For other
resources, destination port might be derived from the referent resource
or this field.
Therefore, when the port is omitted on a Service, we cause all requests to the
backend to fail. This is a jarring user experience.
To improve on this, we can check the port's validity in the admission
controller.
This change adds a validation for Gateway API HTTPRoute resources that
checks that a valid port is specified when a backend is a Service.
olix0r
changed the title
cratelyn
approved these changes
Nov 14, 2024
olix0r
commented
Nov 15, 2024
alpeb
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Gateway API bindings say:
Therefore, when the port is omitted on a Service, we cause all requests to the backend to fail. This is a jarring user experience.
To improve on this, we can check the port's validity in the admission controller.
This change adds a validation for Gateway API HTTPRoute resources that checks that a valid port is specified when a backend is a Service.