-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(viz): add option to add labels to web service #13305
Conversation
Hi, Will be great to get feedback about this :) thanks |
hi @omer2500! thanks for your patience, our team has been a bit busy getting a few new features out the door, followed by the u.s. holiday last week. it looks like the first place to start would be to update the helm docs, which are checked into git as a |
Signed-off-by: Alex Leong <[email protected]>
Thanks for the fix and the merge @adleong i actually wanted to ask what was wrong on the helm docs it seems just the version was changed? am i missing something ? |
@omer2500 that's right, we recently updated the version of our helm tooling. |
Problem
There is no option to add labels to the dashboard service (web) specifically
for example, the use case of service mirror the dashboard service to make it accessible in another cluster needs the label:
Solution
Add option to add labels to dashboard service only
Validation
Run helm templates with couple of use cases to verify it adds new properties while not overwrite others.
I agree to the DCO for all the commits in this PR.