chore(http): rename http/version to http/variant #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy::http::Version type is very similar to the HTTP crate's Version type, though it is more constrained so that the proxy may exhaustively match on it. This change renames the module to http::variant to avoid confusion with the HTTP crate's Version type. To disambiguate the HTTP version type, the proxy::http::Version type is renamed to proxy::http::Variant.
cratelyn
approved these changes
Jan 22, 2025
| @@ -28,7 +28,7 @@ struct Sidecar { | |||
| #[derive(Clone, Debug)] | |||
| struct HttpSidecar { | |||
| orig_dst: OrigDstAddr, | |||
| version: http::Version, | |||
| version: http::Variant, | |||
There was a problem hiding this comment.
🍰 TIOLI: should this field, and others like it, also be renamed to variant? i'm ambivalent about this suggestion, personally, but if the type is being renamed perhaps fields like this should follow suit.
There was a problem hiding this comment.
Yeah, I don't really think there's tremendous value in the type and field names matching. The intent is still that it's an HTTP version, and the type disambiguates what that means, exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy::http::Version type is very similar to the HTTP crate's Version type, though it is more constrained so that the proxy may exhaustively match on it. This change renames the module to http::variant to avoid confusion with the HTTP crate's Version type.
To disambiguate the HTTP version type, the proxy::http::Version type is renamed to proxy::http::Variant.