Differentiate overridden vs inherited super test methods #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a behavior difference betweeen the case of a superclass test method that is not overridden by the subclass, and one that is - when it is not overridden, the actual super method is used, and so all of its annotations remain in tact. However when it _is_ overridden, only inherited annotations are retained. This adds support for handling this difference by splitting the cases when parsing. Also updated tests to be more robust, there were some noticeable gaps. Fixes linkedin#69
drewhannay
reviewed
Aug 24, 2021
parser/src/main/kotlin/com/linkedin/dex/parser/JUnit4Extensions.kt
Outdated
Show resolved
Hide resolved
parser/src/main/kotlin/com/linkedin/dex/parser/JUnit4Extensions.kt
Outdated
Show resolved
Hide resolved
parser/src/main/kotlin/com/linkedin/dex/parser/JUnit4Extensions.kt
Outdated
Show resolved
Hide resolved
drewhannay
reviewed
Aug 30, 2021
| ) | ||
| } | ||
| .toSet() | ||
|
|
||
| return adaptedSuperMethods union parsingResult.testMethods | ||
| // alter the existing test methods to include super annotations if they're inherited | ||
| val alteredMethodsd = parsingResult.testMethods.filter { method -> superTestMethods.any { |
There was a problem hiding this comment.
The keyboard strikes again! alteredMethodsd
drewhannay
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a behavior difference betweeen the case of a superclass test method
that is not overridden by the subclass, and one that is - when it is not overridden,
the actual super method is used, and so all of its annotations remain in tact. However
when it is overridden, only inherited annotations are retained. This adds support for
handling this difference by splitting the cases when parsing.
Also updated tests to be more robust, there were some noticeable gaps.
Fixes #69