Add enum value support #28
Conversation
|
Thanks for the PR, we will review within next two weeks. |
| companion object { | ||
| fun readStringInPosition(dexFile: DexFile, position: Int): String { |
There was a problem hiding this comment.
Thanks for extracting common code into this new function!
There was a problem hiding this comment.
NP: this should probably be a private function, since its only used internally for parsing
| } | ||
| is EncodedValue.EncodedBoolean -> return DecodedBoolean(encodedValue.value) | ||
| is EncodedValue.EncodedNull -> return DecodedNull | ||
|
|
||
| is EncodedValue.EncodedEnum -> { | ||
| val position = dexFile.stringIds[dexFile.fieldIds[encodedValue.value].nameIdx].stringDataOff |
There was a problem hiding this comment.
nitpick: I'd suggest to have a val nameIdx = dexFile.fieldIds[encodedValue.value].nameIdx to make it easier to read and debug if needed
| public void basicJUnit4() { | ||
| assertTrue(true); | ||
| } | ||
|
|
||
| @Test | ||
| @TestValueAnnotation(floatValue = 0.25f, doubleValue = 0.5, byteValue = 0x0f, charValue = '?', shortValue = 3) | ||
| @TestValueAnnotation(floatValue = 0.25f, doubleValue = 0.5, byteValue = 0x0f, charValue = '?', shortValue = 3, enumValue = TestEnum.FAIL) |
There was a problem hiding this comment.
nitpick: I'd keep current pattern that one type only shows up once, either in basicJUnit4() or basicJUnit4Second()
There was a problem hiding this comment.
Would be awesome to also expose the enum type information in the DecodedEnum class, since it can't always be easily inferred and people may want to access it. It can be added separately from this though since it would just be a new field in DecodedEnum class.
Thanks for coming back to implement this, I really appreciate it!
| companion object { | ||
| fun readStringInPosition(dexFile: DexFile, position: Int): String { |
There was a problem hiding this comment.
NP: this should probably be a private function, since its only used internally for parsing
This MR adds support for enum values.
DecodedEnum contains a string value (same as DecodedString)