Add support for test classes that extend other test classes - #13 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports both abstract and concrete superclasses. Normally, test methods are found via reflection which is why methods defined from the super class would be included. This adds the same behavior to dex-test-parser to match with what is expected when running tests via adb directly.
Closed
|
Awesome! |
drewhannay
reviewed
Jul 20, 2018
| @@ -58,7 +58,7 @@ class DexParser private constructor() { | |||
| val dexFiles = Companion.readDexFiles(apkPath) | |||
|
|
|||
| val junit3Items = findJUnit3Tests(dexFiles).sorted() | |||
| val junit4Items = dexFiles.flatMap { it.findJUnit4Tests() }.sorted() | |||
| val junit4Items = findAllJunit4Tests(dexFiles).sorted() | |||
There was a problem hiding this comment.
nitpick: can we use JUnit in this method name to match the other one?
Closed
This is a breaking change to the methods to find JUnit4 methods. Also updated the changelog to indicate this
We want to have a section for the current snapshot, so people can add changes there as they are added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports both abstract and concrete superclasses.
Normally, test methods are found via reflection which is why methods defined from the super class would be included. This
adds the same behavior to dex-test-parser to match with what is expected when running tests via adb directly.