feat: add option to strip non essential fields #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code changes looks ok to me, but it messed up with test i believe ) |
|
@timofei-iatsenko I think I fixed it before you made this comment, would you mind having a look again? I can remove the tests if you think it's overkill |
|
LGTM, could you also add a brief description of this parameter to the package readme? There is code snippet with plugin parameters you can add it there. |
|
@FelixMalfait thanks for the contribution! It would also be great to add a short description of the new parameter here - https://lingui.dev/ref/swc-plugin |
8 tasks
|
Sure! Done |
timofei-iatsenko
approved these changes
Feb 5, 2025
andrii-bodnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
As mentioned in the issue I have no experience with Rust and this is mostly AI generated code, so please close if this is not relevant