chore: compile messages to json #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aseerkt is attempting to deploy a commit to the lingui Team on Vercel. A member of the Team first needs to authorize it. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1888 +/- ##
==========================================
+ Coverage 76.63% 76.65% +0.01%
==========================================
Files 81 81
Lines 2089 2090 +1
Branches 534 533 -1
==========================================
+ Hits 1601 1602 +1
Misses 375 375
Partials 113 113 ☔ View full report in Codecov by Sentry. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
simlmx
reviewed
Mar 19, 2024
| case "es": | ||
| ext = "mjs" | ||
| break | ||
| case "ts": |
There was a problem hiding this comment.
Did you forget to port the "ts" case?
ext = "ts"
breakI'm surprised that the test doesn't catch it!
There was a problem hiding this comment.
Ah nevermind I just understood what you did!
andrii-bodnar
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compile catalogs to JSON
Types of changes
Fixes #1866
Checklist