Avoid recompiling WASM bytecodes #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
approved these changes
May 19, 2023
There was a problem hiding this comment.
Approving because it seems to improve performances and the current situation with #633.
I tried to remove the (partial) workaround with one more commit here: #750 (feel free to cherry-pick)
On my laptop, I couldn't trigger the issue any more (as opposed to removing the workaround on the main branch).
This being said, this PR doesn't quite minimize compilation costs (#739) yet because a bytecode could be shared between several applications. Also, I suspect we could avoid remembering engines with "headless engine" + "module serialization" concepts: https://docs.rs/wasmer/3.1.1/wasmer/struct.Engine.html#method.headless
jvff
force-pushed
the
cache-compiled-wasm-modules
branch
from
bcfbc75 to
d8dbd5b
Compare
Avoid recompiling bytecodes for every execution of the same application.
jvff
force-pushed
the
cache-compiled-wasm-modules
branch
from
d45f48f to
aef4dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
WasmApplicationonly stored the bytecodes for the application, which meant that it recompiled them for every execution. This is inefficient.Solution
Store the compiled
Module(together with the requiredEngineinstance) inWasmApplication.Related Work
Part of #739
Closes #750 by including it