Avoid allocating a String to parse SocketAddr
#2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass a host-port tuple forward, so that only the host `IpAddr` needs to be parsed.
jvff
force-pushed
the
dont-allocate-string-to-parse-socket-addr
branch
from
75e5b62 to
845120d
Compare
christos-h
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I ran into another instance of a
Stringallocation just to parse aSocketAddr. Some of these cases were removed in previous PRs (#2088, #2093).Proposal
Parse only the
IpAddrinstead, reusing the port value. This avoids an allocation and parsing of the port value.Test Plan
This is an internal refactor. Existing tests should catch any regressions.
Release Plan
This is an internal refactor, so nothing is needed.
Links