Add DPI scale factor to the render root state #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it's available to widgets
DJMcNab
reviewed
Feb 18, 2025
as it's not called on dpi changes, so will have outdated info
|
I'll defer to @PoignardAzur, but I am happy to approve in principle, as a stop-gap until we get a more coherent design. (This would also be useful for e.g. Obviously it is true that this value is pretty meaningless for widgets with a transform applied, but that's pretty unavoidable; Transforms are designed to break these kinds of things anyway. |
PoignardAzur
approved these changes
Feb 18, 2025
Since it only causes re-render, so app logic doesn't need it.
let it live in RenderRootState only
DJMcNab
reviewed
Feb 19, 2025
masonry/src/core/contexts.rs
Outdated
Comment on lines
783
to
784
| // Methods on selected context types. | ||
| // Access selected global state information. |
There was a problem hiding this comment.
I think we can just remove these comments - they give very little information.
I'll do this tomorrow if this hasn't landed by then.
| // Methods on selected context types. | ||
| // Access selected global state information. | ||
| impl_context_method!(PaintCtx<'_>, AccessCtx<'_>, { | ||
| /// Get DPI scaling factor. |
There was a problem hiding this comment.
Suggested change
| /// Get DPI scaling factor. | |
| /// Get DPI scaling factor. | |
| /// | |
| /// This is not required for most widgets, and should be used only for precise | |
| /// rendering, such as rendering single pixel lines or selecting image variants. | |
| /// This is currently only provided in the render stages, as these are the only passes which | |
| /// are re-run when the scale factor changes. | |
| /// | |
| /// Note that accessibility nodes and paint results will automatically be scaled by Masonry. | |
| /// This also doesn't account for the widget's current transform, which cannot currently be | |
| /// accessed by widgets directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it's available to widgets that can fix blurry lines due to bad overlapping positioning of its internal elements
partially addresses #869