Support click and drag for svgs, as well as scene fragment caching #244
Conversation
There was a problem hiding this comment.
Confirm this works, and the code looks good. Minor nits in comments.
One thing to mention: because pico_svg currently drops path elements with no fill specified, it's not a full exercise of the paris-30k test. I've locally patched it to just add a default color, but the real solution is to parse attributes in g tags and pass them down so they're inherited.
| use super::pico_svg::*; | ||
| let start = Instant::now(); | ||
| eprintln!("Starting to parse svg"); | ||
| let svg = PicoSvg::load(svg, 6.0).unwrap(); |
There was a problem hiding this comment.
This could be a command line argument (it should be -1.5 for paris), but a more principled approach is to parse transforms in <g> elements.
There was a problem hiding this comment.
I made it a command line flag for now. Properly parsing svg is quite a task.
Some of the work in https://github.com/google/forma/blob/main/demo/src/demos/svg.rs might be useful to us, although forma is Apache only - no MIT option; so we need to be careful that we use it correctly if we do.
Reopen of #236 after it was accidentally closed by GitHub UX.
The new svg example, in
with_winit, now caches theSceneFragment, and allows dragging and scaling the svg (click and drag, and mouse wheel).The scaling is centred on the top left, which isn't ideal, but it works for demonstration. Doing the correct maths centered on the cursor should be reasonably easy, but it takes some thinking
I also added support for closing the window with
Escape, whilst I was editing it.There are two new CLI flags implemented,
sceneandsvg.I have also increased a buffer size to be sufficient for paris-30k (as rendered partially incorrectly currently), until we get #175.