-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shader compilation in GitHub Actions #178
Conversation
This patch sets up very basic CI (right now just cargo fmt) but more importantly compiles shaders in a GitHub Action. Any PR to branches other than main will run shader compilation. Any push to the dev branch will run shader compilation and then merge to main. Closes #177
The CI failed for a technical reason (it doesn't run shader compilation on |
.github/workflows/shader.yml
Outdated
name: compile shaders | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- run: mkdir piet-gpu/shader/gen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding -force
here should suppress the error if the directory already exists. It might be worth not doing this though and just rejecting any PRs that contain the gen directory?
I'm not the most qualified to review GitHub actions, but nothing here stands out as problematic to me. I assume that after this lands, all PRs should be directed to dev? |
Yes. I think something that should happen in this PR is that the README gets updated with clear language describing what's going on. People will want One other question is that we have a few more gen directories (tests, examples for piet-gpu-hal). Should we do all of these so it's consistent? |
Also remove 'shader/gen' gitignore line in main (it's present in dev).
Explain the shader compilation approach. Also add links while I'm at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. Now seems as good a time as any to make the change.
This patch sets up very basic CI (right now just cargo fmt) but more importantly compiles shaders in a GitHub Action.
Any PR to branches other than main will run shader compilation. Any push to the dev branch will run shader compilation and then merge to main.
Closes #177