chore: update to vello 0.4 #49

simbleau · 2025-01-27T15:27:32Z

No description provided.

CHANGELOG.md

waywardmonkeys · 2025-01-27T16:10:18Z

.github/workflows/ci.yml

@@ -152,13 +151,13 @@ jobs:
        os: [windows-latest, macos-latest, ubuntu-latest]
        include:
          - os: ubuntu-latest
-            gpu: 'yes'
+            gpu: "yes"


Why change all of these? Having them differ from all of the other Linebender CI tasks would be annoying. We can change them everywhere, but would want to know why it is needed here.

These got autoformatted since the top of the file uses " instead of '
e.g. RUST_MIN_VER: "1.82"

I think whatever vscode extension I have wanted to make it consistent.

Just don't stage those changes in the PR then, please.

waywardmonkeys · 2025-01-27T16:13:20Z

src/import/converters.rs

+                            values[2] as f32,
+                            values[3] as f32,
+                            values[4] as f32,
+                        ]),


What was the range on these values before? Was it 0.0 to 1.0 or 0 to 255? If it is 0 to 255, then we'll have to divide them here as well.

(Alternatively, use Color::from_rgba()?)

The old Color::rgba method took normalized colors

https://docs.rs/peniko/0.2.0/peniko/struct.Color.html#method.rgba

Logic is correct

(Alternatively, use Color::from_rgba()?)

No such method exists in the new color crate

waywardmonkeys · 2025-01-27T16:15:27Z

src/import/converters.rs

+            Some([x0, x1, x2]) => (*x0, *x1, *x2),
+            _ => (0.0, 0.0, 0.0),
+        };
+        Color::new([x0 as f32, x1 as f32, x2 as f32, 1.0])


Same question about the range of these values here as elsewhere in the PR.

These are normalized, 0.0 to 1.0: https://docs.rs/peniko/0.2.0/peniko/struct.Color.html#method.rgb

The new logic is correct

waywardmonkeys · 2025-01-27T16:15:49Z

src/runtime/model/animated.rs

-            let stop = peniko::ColorStop::from((offset as f32, peniko::Color::rgba(r, g, b, a)));
+            let stop = peniko::ColorStop::from((
+                offset as f32,
+                peniko::Color::new([r as f32, g as f32, b as f32, a as f32]),


And same question here...

(But I do think this one is fine...)

Normalized

https://docs.rs/peniko/0.2.0/peniko/struct.Color.html#method.rgba

Logic is correct

waywardmonkeys · 2025-01-27T16:29:23Z

CHANGELOG.md

@@ -66,6 +70,8 @@ This release has an [MSRV][] of 1.75.

 - Initial release

+[#49][https://github.com/linebender/velato/pull/49]


That's not the right syntax. There is a list of them further below, so it should just at the end of that list, with the right syntax.

Whoops, good catch. Fixed (actually this time).

DJMcNab

Approving to unblock. I haven't carefully reviewed this code

DJMcNab · 2025-01-28T17:19:18Z

src/runtime/model/value.rs

@@ -139,8 +149,8 @@ pub struct Animated<T: Tween> {

 impl<T: Tween> Animated<T> {
    /// Returns the value at the specified frame.


What does a "failure" here (where the or would be used) mean? Should we document that?

I'd naively expect it to e.g. return the first value of the t is before the timeline, and the last if after, instead.

The action for this comment would be documentation, not changing behaviour. And this needn't block this pr.

The new Color doesn't have Default, so I had to add a new method, _or which passes in a provided default.

xStrom · 2025-01-30T16:34:12Z

src/schema/shapes/mod.rs

+    not(target_arch = "wasm32"),
+    expect(
+        clippy::large_enum_variant,
+        reason = "Deferred. Furthermore, for some reason, only on wasm32, this isn't triggering clippy."


Probably because of an internal isize.

xStrom · 2025-01-30T16:35:18Z

src/schema/assets/image.rs

@@ -42,7 +42,7 @@ where
 }

 // Function signature must match Serde's Serialize trait, so need to suppress Clippy.
-#[allow(clippy::trivially_copy_pass_by_ref)]
+#[expect(clippy::trivially_copy_pass_by_ref, reason = "Deferred")]


The reason is present in the comment above.

Suggested change

#[expect(clippy::trivially_copy_pass_by_ref, reason = "Deferred")]

#[expect(clippy::trivially_copy_pass_by_ref, reason = "Function signature must match Serde's Serialize trait")]

chore: update to vello 0.4

8881dee

simbleau requested review from waywardmonkeys and DJMcNab January 27, 2025 15:27

simbleau added 6 commits January 27, 2025 10:29

build: use transparent instead

671bdda

fix: changelog and msrv

469edf0

fix: msrv

8de2250

docs: adjust msrv

b7785e6

fix: lints

b1a301c

fix: clippy lints

8c92202

waywardmonkeys reviewed Jan 27, 2025

View reviewed changes

simbleau added 3 commits January 27, 2025 11:20

fix: clippy lint

766c6db

build: revert this lint

b47394b

fix: missing #49

58beeb5

waywardmonkeys reviewed Jan 27, 2025

View reviewed changes

simbleau added 2 commits January 27, 2025 11:49

fix: syntax on external link

d151ebe

build: unstage double quotes

538d84e

simbleau requested a review from waywardmonkeys January 27, 2025 17:00

simbleau added 2 commits January 27, 2025 12:26

fix: satisfy clippy

e170b42

fix: add back unused crate deps

c0dfedd

simbleau mentioned this pull request Jan 28, 2025

Bevy v0.15.0 linebender/bevy_vello#87

Merged

DJMcNab approved these changes Jan 28, 2025

View reviewed changes

simbleau added this pull request to the merge queue Jan 30, 2025

Merged via the queue into main with commit db7617a Jan 30, 2025
16 checks passed

simbleau deleted the simbleau/vello-0.4 branch January 30, 2025 16:31

xStrom reviewed Jan 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update to vello 0.4 #49

chore: update to vello 0.4 #49

simbleau commented Jan 27, 2025

waywardmonkeys Jan 27, 2025

simbleau Jan 27, 2025 •

edited

Loading

waywardmonkeys Jan 27, 2025

simbleau Jan 27, 2025

waywardmonkeys Jan 27, 2025

waywardmonkeys Jan 27, 2025

simbleau Jan 27, 2025

waywardmonkeys Jan 27, 2025

simbleau Jan 27, 2025

waywardmonkeys Jan 27, 2025

waywardmonkeys Jan 27, 2025

simbleau Jan 27, 2025

waywardmonkeys Jan 27, 2025

simbleau Jan 27, 2025

DJMcNab left a comment

DJMcNab Jan 28, 2025

simbleau Jan 28, 2025

xStrom Jan 30, 2025

xStrom Jan 30, 2025

		@@ -66,6 +70,8 @@ This release has an [MSRV][] of 1.75.

		- Initial release

		[#49][https://github.com/linebender/velato/pull/49]

		@@ -139,8 +149,8 @@ pub struct Animated<T: Tween> {

		impl<T: Tween> Animated<T> {
		/// Returns the value at the specified frame.

	#[expect(clippy::trivially_copy_pass_by_ref, reason = "Deferred")]
	#[expect(clippy::trivially_copy_pass_by_ref, reason = "Function signature must match Serde's Serialize trait")]

chore: update to vello 0.4 #49

chore: update to vello 0.4 #49

Conversation

simbleau commented Jan 27, 2025

Choose a reason for hiding this comment

simbleau Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DJMcNab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simbleau Jan 27, 2025 •

edited

Loading