Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3 #24

Merged
merged 4 commits into from
Jul 3, 2024
Merged

v0.3 #24

merged 4 commits into from
Jul 3, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Jul 3, 2024

0.3.0

Added

  • Added velato::Renderer::render, which now returns a new vello scene.

Changed

  • Updated to vello 0.2
  • Renamed VelatoError to velato::Error
  • Renamed the existing velato::Renderer::render to velato::Renderer::append

Removed

  • All code and related profiling (wgpu_profiler) used in examples.

@simbleau simbleau added the release This PR will be followed by a public release. label Jul 3, 2024
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard optimistic approval for Velato

I have not tested this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be inclined to put this in src/lib.rs

@simbleau simbleau added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 23353c9 Jul 3, 2024
9 checks passed
@simbleau simbleau deleted the v0.3 branch July 3, 2024 19:42
@@ -3,10 +3,12 @@

//! Render a Lottie animation to a Vello [`Scene`](crate::vello::Scene).
//!
//! However, this is also intended to be the preferred integration between Vello and [Lottie](https://lottie.github.io/lottie-spec/), so [consider
//! contributing](https://github.com/linebender/velato) if you need a feature which is missing.
//! This currently lacks support for a [number of important](crate#unsupported-features) SVG features.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are Velato/Lottie and SVG related?

Copy link
Member Author

@simbleau simbleau Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo, probably since we copied this part from vello_svg.

Velato renders Lottie files only. We have another crate, vello_svg, which renders SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release This PR will be followed by a public release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants