-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3 #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standard optimistic approval for Velato
I have not tested this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be inclined to put this in src/lib.rs
@@ -3,10 +3,12 @@ | |||
|
|||
//! Render a Lottie animation to a Vello [`Scene`](crate::vello::Scene). | |||
//! | |||
//! However, this is also intended to be the preferred integration between Vello and [Lottie](https://lottie.github.io/lottie-spec/), so [consider | |||
//! contributing](https://github.com/linebender/velato) if you need a feature which is missing. | |||
//! This currently lacks support for a [number of important](crate#unsupported-features) SVG features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are Velato/Lottie and SVG related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typo, probably since we copied this part from vello_svg.
Velato renders Lottie files only. We have another crate, vello_svg, which renders SVG.
0.3.0
Added
velato::Renderer::render
, which now returns a new vello scene.Changed
VelatoError
tovelato::Error
velato::Renderer::render
tovelato::Renderer::append
Removed
wgpu_profiler
) used in examples.