Replace vello's default wgpu feature with an optional wgpu feature
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the same fix needs to be applied to |
MarijnS95
force-pushed
the
vello-no-default
branch
from
5e0993f to
90c3063
Compare
|
Can you explain why we wouldn't want the default feature for |
|
So that crates using |
|
Please update the CHANGELOG and I can merge this |
|
Before pushing an updated changelog: since this crate reexports |
|
Yeah, let's do that. |
MarijnS95
force-pushed
the
vello-no-default
branch
from
90c3063 to
a9f2971
Compare
|
@simbleau done. |
MarijnS95
changed the title
vello to remove wgpuwgpu feature with an optional vello-wgpu feature
simbleau
requested changes
May 3, 2024
…ature linebender/vello#359 made `wgpu` an optional but default dependency/feature, but any crate using `velato` will be forced to opt in to `wgpu` due to not disabling the default here. Since `velato` does not need any rendering backend at all, this feature should be disabled by default. As the `vello` crate is reexported from the root, a `wgpu` passthrough feature is provided so that users can turn it back on without explicitly depending on `vello` in their crate dependencies.
MarijnS95
force-pushed
the
vello-no-default
branch
from
a9f2971 to
0119c07
Compare
github-merge-queue bot
pushed a commit
to linebender/vello_svg
that referenced
this pull request
May 5, 2024
…feature (#10) linebender/vello#359 made `wgpu` an optional but default dependency/feature, but any crate using `vello_svg` will be forced to opt in to `wgpu` due to not disabling the default here. Since `vello_svg` does not need any rendering backend at all, this feature should be disabled by default. As the `vello` crate is reexported from the root, a `vello-wgpu` passthrough feature is provided so that users can turn it back on without explicitly depending on `vello` in their crate dependencies. Same change as linebender/velato#17.
github-merge-queue bot
pushed a commit
to linebender/vello_svg
that referenced
this pull request
May 5, 2024
#10) linebender/vello#359 made `wgpu` an optional but default dependency/feature, but any crate using `vello_svg` will be forced to opt in to `wgpu` due to not disabling the default here. Since `vello_svg` does not need any rendering backend at all, this feature should be disabled by default. As the `vello` crate is reexported from the root, a `vello-wgpu` passthrough feature is provided so that users can turn it back on without explicitly depending on `vello` in their crate dependencies. Same change as linebender/velato#17.
MarijnS95
changed the title
wgpu feature with an optional vello-wgpu featurewgpu feature with an optional wgpu feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linebender/vello#359 made
wgpuan optional but default dependency/feature, but any crate usingvelatowill be forced to opt in towgpudue to not disabling the default here.Since
velatodoes not need any rendering backend at all, this feature should be disabled by default. As thevellocrate is reexported from the root, avello-wgpupassthrough feature is provided so that users can turn it back on without explicitly depending onvelloin their crate dependencies.Note that
with_winitruns briefly (withwgpu), but if I don't manage to immediately fullscreen it, it panics:This is on a Wayland compositor with AMD GPU. I'm not a WGPU expert and don't dare to immediately say where it is being used wrong.