-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune the canonical lint set #88
Conversation
We've had complaints that the lint set is too strict, which I think is fair. As such, some of the most Of note: 1) `allow_attributes` is removed from the default set. This doesn't mean we shouldn't still aim to use `expect`, but having an allow is fine. 2) `default_trait_access` is *added* to the new "periodic" category. 3) `missing_panics_doc` is removed entrely. 4) `wildcard_imports` is removed entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I think removing match_same_arms
from the default set is particularly good. It's a good lint some times, but we also have existing code where it clearly makes things worse.
On further thought, are there examples of issues with @waywardmonkeys you've been the biggest implementor of this. What's your take, should we keep it on by default? |
I think |
We can also have CI run a job periodically (every Monday morning?) that runs the periodic checks. |
I removed
Certainly happy to optimistically restore it, though. A weekly check with a Zulip webhook message for the periodic checks might be nice. I suspect that's too much effort for the amount of gain (i.e. that re-adding them to CI proper would probably be better than that...), but I could be convinced. |
See linebender/linebender.github.io#88 (and some other earlier PRs) A follow up like linebender/vello#806 will also be needed, but that can come later.
We've had complaints that the lint set is too strict, which I think is fair. As such, I suggest that we remove some of the most pedantic lints. It also adds a new set which we "want to" follow, but which don't block PRs.
It's expected that we would work to not regress these between (for example) crate releases.
Of note:
allow_attributes
is removed from the default set. This doesn't mean we shouldn't still aim to useexpect
, but having an allow is fine.default_trait_access
is newly added to the new "periodic" category.missing_panics_doc
is removed entirely.wildcard_imports
is removed entirely