Rely on defined saturation behavior for f32 to u8 casts #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of a change from Raph made in the CPU sparse strips experiment. When converting from `f32` to `u8`, the code was clamping to be sure that the values were within range. This was necessary in the past, but hasn't been needed for some years now, since <rust-lang/rust#10184>. This clamping is not necessary and the compiler is not optimizing it away as of Rust 1.83 on Apple Silicon.
DJMcNab
approved these changes
Dec 11, 2024
tomcur
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of a change from Raph made in the CPU sparse strips experiment.
When converting from
f32tou8, the code was clamping to be sure that the values were within range. This was necessary in the past, but hasn't been needed for some years now, since rust-lang/rust#10184. This clamping is not necessary and the compiler is not optimizing it away as of Rust 1.83 on Apple Silicon.