Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Stricter validation #476

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[BUGFIX] Stricter validation #476

merged 1 commit into from
Feb 12, 2024

Conversation

kfdm
Copy link
Contributor

@kfdm kfdm commented Feb 9, 2024

Previously some of our regex checks were not properly bounded. By adding ^ and $ to our regex, we can ensure the entire string gets checked.

@kfdm
Stricter validation
7fadbc4 
Previously some of our regex checks were not properly bounded. By adding
^ and $ to our regex, we can ensure the entire string gets checked.
@kfdm kfdm requested a review from a team as a code owner February 9, 2024 05:37
@kfdm kfdm merged commit 927765d into line:master Feb 12, 2024
@kfdm kfdm deleted the stricter-validation branch February 12, 2024 23:54
@vincent-olivert-riera vincent-olivert-riera mentioned this pull request Feb 14, 2025
Open
hoangpn added a commit to hoangpn/promgen that referenced this pull request Feb 14, 2025
@hoangpn
Add a missing migration for the change in regex validation
f87c411 
A migration file is generated corresponding to the regex change of labelname in commit 7fadbc4.
This migration script was forgotten on a previous pull request
(line#476).
@hoangpn hoangpn mentioned this pull request Feb 14, 2025
Merged
hoangpn added a commit to hoangpn/promgen that referenced this pull request Feb 14, 2025
@hoangpn
Add a missing migration for the change in regex validation
90916bb 
A migration file is generated corresponding to the regex change of labelname in commit 7fadbc4.
This migration script was forgotten on a previous pull request
(line#476).
hoangpn added a commit to hoangpn/promgen that referenced this pull request Feb 14, 2025
@hoangpn
Add a missing migration for the change in regex validation
6533c29 
A migration file is generated corresponding to the regex change of labelname in commit 7fadbc4.
This migration script was forgotten on a previous pull request
(line#476).
hoangpn added a commit to hoangpn/promgen that referenced this pull request Feb 14, 2025
@hoangpn
Add a missing migration for the change in regex validation
7d9207d 
A migration file is generated corresponding to the regex change of labelname in commit 7fadbc4.
This migration script was forgotten on a previous pull request
(line#476).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh-kawakami sh-kawakami sh-kawakami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfdm @sh-kawakami