Add WithImageOptions for buttons/carousel templates #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2017/11/30 New options for template message images: "We have released imageAspectRatio, imageSize, and imageBackgroundColor fields for Buttons and Carousel template messages. Using these fields, you can configure the aspect ratio, size, and background color for images used in template messages." Ref: - https://developers.line.me/en/docs/messaging-api/reference/#buttons - https://developers.line.me/en/docs/messaging-api/reference/#carousel
|
Issue: #67 |
|
@clsung |
|
@sugyan please help to review again, thank you. |
|
LGTM. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: for backward compatibility (and not breaking any client library who use this SDK), I choose to use WithImageOptions() and return the object itself.
2017/11/30 New options for template message images:
"We have released imageAspectRatio, imageSize, and imageBackgroundColor
fields for Buttons and Carousel template messages. Using these fields,
you can configure the aspect ratio, size, and background color for
images used in template messages."
Ref: