Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #156 no 6 Support get number of sent broadcast messages. #169

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Fix #156 no 6 Support get number of sent broadcast messages. #169

merged 1 commit into from
Jul 9, 2019

Conversation

kkdai
Copy link
Member

@kkdai kkdai commented Jun 28, 2019

@codecov-io
Copy link

Codecov Report

Merging #169 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #169     +/-   ##
=========================================
- Coverage   73.15%   72.95%   -0.2%     
=========================================
  Files          24       24             
  Lines        1866     1871      +5     
=========================================
  Hits         1365     1365             
- Misses        418      423      +5     
  Partials       83       83
Impacted Files Coverage Δ
linebot/delivery.go 69.69% <0%> (-12.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e3584...cf5bab0. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 28, 2019 •
edited
Loading

Codecov Report

Merging #169 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #169     +/-   ##
=========================================
- Coverage   73.15%   72.95%   -0.2%     
=========================================
  Files          24       24             
  Lines        1866     1871      +5     
=========================================
  Hits         1365     1365             
- Misses        418      423      +5     
  Partials       83       83
Impacted Files Coverage Δ
linebot/delivery.go 69.69% <0%> (-12.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e3584...cf5bab0. Read the comment docs.

@tkgauri tkgauri requested a review from nasa9084 July 5, 2019 05:37
@k2wanko k2wanko self-requested a review July 5, 2019 05:43
nasa9084
nasa9084 approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai
Copy link
Member Author

kkdai commented Jul 9, 2019

Hi @k2wanko
Please let me know if you have any question for this PR, thank you.

@k2wanko
Copy link
Contributor

k2wanko commented Jul 9, 2019

@kkdai
Thank you.

@k2wanko k2wanko merged commit 259dbdb into line:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k2wanko k2wanko k2wanko approved these changes

@nasa9084 nasa9084 nasa9084 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkdai @codecov-io @k2wanko @nasa9084