Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/typo #166

Merged
merged 2 commits into from
Jun 24, 2019
Merged

fix/typo #166

merged 2 commits into from
Jun 24, 2019

Conversation

nasa9084
Copy link
Member

No description provided.

@nasa9084 nasa9084 self-assigned this Jun 24, 2019
@tkgauri
Copy link
Contributor

tkgauri commented Jun 24, 2019 •
edited
Loading

[NITS] Provide logs if possible is repeated. IMO, first one(L18) is unnecessary.

@codecov-io
Copy link

codecov-io commented Jun 24, 2019 •
edited
Loading

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   72.46%   72.46%           
=======================================
  Files          23       23           
  Lines        1776     1776           
=======================================
  Hits         1287     1287           
  Misses        412      412           
  Partials       77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8343b...2fa05f7. Read the comment docs.

@nasa9084
Copy link
Member Author

@tkgauri Thank you, I removed it

@suzuki-shunsuke suzuki-shunsuke self-requested a review June 24, 2019 08:48
suzuki-shunsuke
suzuki-shunsuke approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzuki-shunsuke suzuki-shunsuke merged commit 06481bc into master Jun 24, 2019
@Yang-33 Yang-33 deleted the fix/typo branch October 31, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-shunsuke suzuki-shunsuke suzuki-shunsuke approved these changes

Assignees

@nasa9084 nasa9084

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nasa9084 @tkgauri @codecov-io @suzuki-shunsuke