Add WithNotificationDisabled() to push/reply/multicast message API #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 72.46% 72.74% +0.27%
==========================================
Files 23 23
Lines 1776 1794 +18
==========================================
+ Hits 1287 1305 +18
Misses 412 412
Partials 77 77
Continue to review full report at Codecov.
|
|
I think your summary is not match with the changes of code... |
clsung
changed the title
clsung
force-pushed
the
enhanced_message_api
branch
from
2e7d013 to
1eb3e0e
Compare
clsung
force-pushed
the
enhanced_message_api
branch
3 times, most recently
from
1b9cd33 to
f5eaaff
Compare
- support notificationDisabled, which is added to API recently. - add omitempty to `notificationDisabled` since it's optional
clsung
force-pushed
the
enhanced_message_api
branch
from
f5eaaff to
c5243e9
Compare
|
@clsung Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notificationDisabledsince it's optional