Alternative to implement #152, quota consumption. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- not like line#149, I'll suggest make quota's query code in the same Call() 1 quota/consumption is placed under quota/ 2 developer, when calling quota functions, only need to take care of one invoker aka GetMessageQuotaCall and one response aka MessageQuotaResponse - final decision is left to repo commiters
clsung
changed the title
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 72.11% 72.19% +0.07%
==========================================
Files 23 23
Lines 1757 1762 +5
==========================================
+ Hits 1267 1272 +5
Misses 413 413
Partials 77 77
Continue to review full report at Codecov.
|
|
Agree, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 quota/consumption is placed under quota/
2 developer, when calling quota functions, only need to take care
of one invoker aka GetMessageQuotaCall and one response aka MessageQuotaResponse
3 in MessageQuotaResponse, totalUsage is sufficient to distinguish from quota (Value)