Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Send broadcast api" #151

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Support "Send broadcast api" #151

merged 2 commits into from
Jun 25, 2019

Conversation

kkdai
Copy link
Member

@kkdai kkdai commented May 3, 2019

Sends push messages to multiple users at any time.

Refer https://developers.line.biz/en/reference/messaging-api/#send-broadcast-message

@codecov-io
Copy link

codecov-io commented May 4, 2019

Codecov Report

Merging #151 into master will increase coverage by 0.24%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   72.39%   72.63%   +0.24%     
==========================================
  Files          23       23              
  Lines        1782     1805      +23     
==========================================
+ Hits         1290     1311      +21     
- Misses        414      415       +1     
- Partials       78       79       +1
Impacted Files Coverage Δ
linebot/client.go 74.32% <ø> (ø) ⬆️
linebot/send_message.go 92.07% <91.3%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebf117...3924eb3. Read the comment docs.

@kkdai kkdai force-pushed the send-broadcast-api branch from edd5323 to 3924eb3 Compare May 19, 2019 17:16
@kkdai
Copy link
Member Author

kkdai commented May 19, 2019

fixed #156

@kkdai
Copy link
Member Author

kkdai commented May 26, 2019

Fixed for #158

@tkgauri tkgauri requested a review from k2wanko May 28, 2019 08:01
@kkdai
Copy link
Member Author

kkdai commented Jun 9, 2019

Hi @k2wanko
Could you help to check this PR? Thank you.

@notsu
Copy link
Contributor

notsu commented Jun 25, 2019

Hi @sugyan,

Could you please review this PR? This PR might be useful for every developer to use broadcast API 😁

@k2wanko k2wanko merged commit 3924eb3 into line:master Jun 25, 2019
@k2wanko
Copy link
Contributor

k2wanko commented Jun 25, 2019

@kkdai Thank you.

@k2wanko k2wanko removed their request for review June 25, 2019 08:06
k2wanko added a commit that referenced this pull request Jun 25, 2019
k2wanko pushed a commit that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants