Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new EventType. #117

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Add new EventType. #117

merged 4 commits into from
Nov 30, 2018

Conversation

toyo
Copy link
Contributor

@toyo toyo commented Nov 30, 2018

Add new EventType for LINE Things, etc.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sugyan
Copy link
Contributor

sugyan commented Nov 30, 2018

Thanks for your contribution!
We adopted #116 first, so the coflict occurred.
Could you resolve the conflict and write tests about things events? 🙇

@toyo
Copy link
Contributor Author

toyo commented Nov 30, 2018

done.

@sugyan
Copy link
Contributor

sugyan commented Nov 30, 2018

LGTM. Thanks!

@sugyan sugyan merged commit 61d5e37 into line:master Nov 30, 2018
@sugyan sugyan mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toyo @CLAassistant @sugyan