Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire reviewdog and update travis.yml #113

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Retire reviewdog and update travis.yml #113

merged 1 commit into from
Nov 20, 2018

Conversation

sugyan
Copy link
Contributor

@sugyan sugyan commented Nov 16, 2018

Try golint and go vet in travis.yml because reviewdog often fails...

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sugyan
Copy link
Contributor Author

sugyan commented Nov 16, 2018

CI fails but I think that it will be fixed by #114

@sugyan sugyan requested review from k2wanko and suzuki-shunsuke and removed request for k2wanko November 16, 2018 09:57
@sugyan
Copy link
Contributor Author

sugyan commented Nov 20, 2018

CI succeeded.

@sugyan sugyan merged commit d3a1495 into line:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-shunsuke suzuki-shunsuke Awaiting requested review from suzuki-shunsuke

@k2wanko k2wanko Awaiting requested review from k2wanko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sugyan @CLAassistant