Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version of linebot/version.go and add a shell script to prevent to forget update of linebot/version.go . #103

Merged
merged 4 commits into from
Aug 29, 2018

Conversation

suzuki-shunsuke
Copy link
Contributor

No description provided.

Close #102

When release the new version, please execute the script.
For example,

```
$ bash script/tag.sh v3.0.1
```

Then linebot/version.go is updated and is commited and a new tag is created.
@sugyan sugyan self-requested a review August 29, 2018 05:40

echo "create linebot/version.go"
cat << EOS > linebot/version.go
// Copyright 2016 LINE Corporation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry..

Copy link
Contributor Author

@suzuki-shunsuke suzuki-shunsuke Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I misunderstood.
This 2016 is correct. linebot/version.go has created before 2018.
I should add LICENSE at the head of tag.sh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the license.
87cba7b

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I was wrong, thank you 🙇

@sugyan sugyan self-requested a review August 29, 2018 06:01
Copy link
Contributor

@sugyan sugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

@sugyan sugyan merged commit 08e95c7 into line:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants