Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide init command #2

Merged
merged 12 commits into from
Feb 19, 2025
Merged

feat: Provide init command #2

merged 12 commits into from
Feb 19, 2025

Conversation

coffeephile
Copy link
Contributor

@coffeephile coffeephile commented Jan 17, 2025 •
edited
Loading

Provide init command

How to test:

  1. npm run build
  2. run without parameters:
    npm run start init
  3. run with parameters (example):
    npm run start init -- -c {LIFF-ID} -n {APP-NAME} -v tall -e https://localhost:9000

@coffeephile coffeephile self-assigned this Jan 17, 2025
@coffeephile coffeephile changed the title provide init command feat: Provide init command Jan 17, 2025
@CLAassistant
Copy link

CLAassistant commented Jan 31, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coffeephile coffeephile marked this pull request as ready for review February 17, 2025 07:04
@coffeephile coffeephile requested a review from a team as a code owner February 17, 2025 07:04
odanado
odanado reviewed Feb 17, 2025
View reviewed changes
@coffeephile
Copy link
Contributor Author

@odanado Thanks for your suggestions, added them 👍

@coffeephile coffeephile requested a review from odanado February 18, 2025 04:21
odanado
odanado approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@odanado odanado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

kazuma0129
kazuma0129 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@kazuma0129 kazuma0129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeephile coffeephile merged commit ef1f334 into main Feb 19, 2025
3 checks passed
@coffeephile coffeephile deleted the add-init-command branch February 19, 2025 01:04
@odanado odanado mentioned this pull request Mar 13, 2025
Merged
odanado added a commit that referenced this pull request Mar 13, 2025
@odanado
docs: Add a section of Init command to README.md (#11)
3861daa 
related: #2

# Description

Although the init command was added, the README was not updated, so I
updated the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odanado odanado odanado approved these changes

@kazuma0129 kazuma0129 kazuma0129 approved these changes

Assignees

@coffeephile coffeephile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coffeephile @CLAassistant @odanado @kazuma0129