Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose useful configurations with agnostic way #47

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

hexoul
Copy link
Collaborator

@hexoul hexoul commented Aug 20, 2024

Motivation

Modifications

  • Expose useful configurations, retries, max_connections and max_keepalive_connections. Default values are same with httpx.
  • misc.
    • Leave TODO to consecutive work for automatic retry.
    • Upgrade Github action versions.
    • Revise README.

Result

  • Dogma client become a little bit more agnostic.

@hexoul hexoul added this to the 0.4.0 milestone Aug 20, 2024
@hexoul hexoul requested review from ikhoon and minwoox August 20, 2024 12:24
@hexoul hexoul changed the title Improve BaseClient by making it agnostic Expose useful configurations with agnostic way Aug 20, 2024
@hexoul hexoul changed the title Expose useful configurations with agnostic way WIP: Expose useful configurations with agnostic way Aug 20, 2024
@hexoul hexoul changed the title WIP: Expose useful configurations with agnostic way Expose useful configurations with agnostic way Aug 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (045d77a) to head (eee8a28).

❗ There is a different number of reports uploaded between BASE (045d77a) and HEAD (eee8a28). Click for more details.

HEAD has 17 uploads less than BASE
Flag BASE (045d77a) HEAD (eee8a28)
18 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #47       +/-   ##
===========================================
- Coverage   93.74%   81.30%   -12.44%     
===========================================
  Files          23       23               
  Lines         703      706        +3     
===========================================
- Hits          659      574       -85     
- Misses         44      132       +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks always! 🙇‍♂️🙇‍♂️

@hexoul hexoul merged commit 935a447 into line:main Sep 13, 2024
22 checks passed
@hexoul hexoul deleted the improve/baseclient branch September 13, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants