-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts update #165
Scripts update #165
Conversation
brkomir
commented
Oct 24, 2024
•
edited
Loading
edited
- introduced common scripts for keeper actions - rebalance, reallocate, and exit all positions
- updated the deployment scripts to use create for deterministic deploys
- added deploy and keeper scripts for scUSDT and scSDAI
- other refactoring and improvements to all script files
script/base/MainnetAddresses.sol
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add the other deployed addresses too
/ scUSDT: 0x237eCDF745d2a0052AeaF6f027ce82F77431871E
// scUSDT AaveV3Adapter: 0x795FDAC1bB26D219991f1923190cA7eB0046e32E
// scUSDT swapper: 0xcD0Ae497068980ce94fbe20A6F7431329F0e4D08
// scUSDT priceConverter: 0x8e045458385d51d047bCA5b2B3b74053e235f5F9
// scSdai: 0x0Fc97657B67C7E7bD4100c72851d0377DA14B470
// scDai: 0x16f3cdA06743a58bDdE123687F99E80DCbc28d14
// scSdai sparkAdapter: 0xeD81a1D7cb2AdC2ee379B594e0dA6a988a865ae4
// scSdai swapper: 0x3F76D80dfc54677262FeA7E94a73D96aC69F4A10
// scSdai priceConverter: 0x0dD22Ebc502f328b29a19Bf0A74373B03DfD374c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for these addresses, i'll update the relevant files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of these contracts have been already deployed already. Do we still have any use for the deploy scripts of those contracts? |
I would say we do since we want to maintain consistency with our deployments utilizing CREATE2. At the very least, these scripts are using common deployment logic tested through these specific deployment scripts, so even if we end up not using them in the future, they are pinning down this base logic. |