Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $FZF_COMPLETION_TMUX_LEGACY for Flexible tmux Integration #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stonematt
Copy link

This update introduces the $FZF_COMPLETION_TMUX_LEGACY environment variable, giving users the flexibility to switch between the legacy fzf-tmux wrapper and the modern fzf --tmux integration. By default, $FZF_COMPLETION_TMUX_LEGACY is set to true, preserving the current behavior. When set to false, it leverages native fzf --tmux, fixing command interpretation issues like:

bash: fzf-tmux --height=40% -- : command not found

The README has been updated with instructions for using the new environment variable and includes a tip on enabling fzf’s tmux mode (export FZF_TMUX=1) for smoother completion experiences, as suggested in the fzf README.

Key Changes:

  • Enhanced fzf_bash_completion_selector to switch between legacy and native tmux handling based on $FZF_COMPLETION_TMUX_LEGACY.
  • Updated the README to include the new variable and a tip for enabling tmux mode with fzf.

Why This Change:

This fixes known issues with legacy fzf-tmux command interpretation while allowing users to switch to the more robust native fzf --tmux integration for enhanced reliability.

Testing:

  • Verified both legacy and native tmux modes work as expected in bash with and without tmux.
  • Confirmed proper fallback behavior in case of missing configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant