Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3514 Detect base64 image to transfer it to cid attachment #3531

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Mar 5, 2025

Issue

#3514

Resolved

Screen.Recording.2025-03-05.at.02.26.26.online-video-cutter.com.mp4
  • Integration test log:
🧪 Should see inline image with cid when reply email with content contain base64 image
        ✅   1. waitUntilVisible widgets with type "TwakeWelcomeView".
        ✅   2. tap widgets with text "Use company server".
        ✅   3. waitUntilVisible widgets with type "LoginView".
        ✅   4. tap widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
        ✅   5. enterText widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
        ✅   6. waitUntilVisible widgets with text "bob".
        ✅   7. tap widgets with text "Next".
        ✅   8. waitUntilVisible widgets with key [<'base_url_form'>] descending from widgets with type "LoginView".
        ✅   9. tap widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
        ✅  10. enterText widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
        ✅  11. waitUntilVisible widgets with text containing c70c-42-118-107-204.ngrok-free.app.
        ✅  12. tap widgets with text "Next".
        ✅  13. waitUntilVisible widgets with key [<'credential_input_form'>] descending from widgets with type "LoginView".
        ✅  14. enterText widgets with type "TextField" descending from widgets with key [<'login_username_input'>].
        ✅  15. waitUntilVisible widgets with text "[email protected]".
        ✅  16. tap widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
        ✅  17. enterText widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
        ✅  18. tap widgets with key [<'loginSubmitForm'>].
        ✅  19. isPermissionDialogVisible (native)
        ✅  20. waitUntilVisible widgets with type "ThreadView".
        ✅  21. tap widgets with type "InkWell" descending from widgets with type "SearchBarView".
        ✅  22. waitUntilVisible widgets with type "SearchEmailView".
        ✅  23. enterText widgets with type "TextField" descending from widgets with key [<'search_email_text_field'>].
        ✅  24. waitUntilVisible widgets with text "Showing results for:".
        ✅  25. tap widgets with text "Showing results for:".
        ✅  26. waitUntilVisible widgets with key [<'search_email_list_notification_listener'>].
        ✅  27. tap widgets with widget matching predicate descending from widgets with type "EmailTileBuilder" inclusive.
        ✅  28. waitUntilVisible widgets with type "EmailView".
        ✅  29. waitUntilVisible widgets with key [<'reply_email_button'>].
✅ Should see inline image with cid when reply email with content contain base64 image (integration_test/tests/compose/reply_email_with_content_contain_base64_image_test.dart) (47s)

Test summary:
📝 Total: 1
✅ Successful: 1
❌ Failed: 0
⏩ Skipped: 0
⏱️  Duration: 72s

Copy link

github-actions bot commented Mar 5, 2025

This PR has been deployed to https://linagora.github.io/tmail-flutter/3531.

tddang-linagora
tddang-linagora previously approved these changes Mar 6, 2025
@dab246 dab246 force-pushed the improvement/tf-3514-detect-base64-image-to-transfer-it-to-cid-attachment branch from d6c8fd7 to 1a9bb3c Compare March 6, 2025 04:42
@dab246 dab246 force-pushed the improvement/tf-3514-detect-base64-image-to-transfer-it-to-cid-attachment branch from 1a9bb3c to 474357e Compare March 6, 2025 04:47
@dab246 dab246 force-pushed the improvement/tf-3514-detect-base64-image-to-transfer-it-to-cid-attachment branch from 7d5b6af to f100bdd Compare March 7, 2025 09:37
@dab246 dab246 force-pushed the improvement/tf-3514-detect-base64-image-to-transfer-it-to-cid-attachment branch from f100bdd to 11dcf68 Compare March 7, 2025 09:48
@hoangdat
Copy link
Member

hoangdat commented Mar 7, 2025

  • when we have multiple base 64 images, I have a problem @dab246
Screenshot 2025-03-07 at 19 49 52

Maybe a blocking in IntecepterQueue.

@dab246
Copy link
Member Author

dab246 commented Mar 10, 2025

  • when we have multiple base 64 images, I have a problem @dab246

Fixed.

Screen.Recording.2025-03-10.at.15.14.25.online-video-cutter.com.mp4

@hoangdat hoangdat merged commit 0e2ea6a into master Mar 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants