-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JasminResult.run() not working #3
base: main
Are you sure you want to change the base?
Conversation
Once again, thank you for your PR! Personally, I didn't plan on supporting compiled code execution in the website but, if we go with that route, we need to address two main concerns:
What do you think? |
You're right, that's definitely the better way of doing things, I just sort of hacked it to work with my compiler.
Yeah, I hadn't thought of that, although infinite loops don't seem to break my deployment. |
Yeah, that would also solve the problem with the config.properties file in my compiler! Are you going to investigate that or do you prefer it if I do it?
That's interesting. Technically, the website waits for the compiler process to exit 🤔 |
I don't plan on spending more time on this, at least for now, so feel free to close this PR if you prefer! |
I'll keep this open and pick it up when I have the time. |
JasminResult.run()
had two problems in my compiler deployment, namely: thelibs-jmm
directory was required to be able to interact with the outside world, andbash
was also required to run the program, which wasn't available in the alpine based image