Splitted https://lima-vm.io/docs/config/network/ to multiple pages #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairveeehh
force-pushed
the
master
branch
4 times, most recently
from
c7b86d8 to
f078195
Compare
|
@AkihiroSuda , after a lot of mistakes that I made I finally understood what you meant by automatic ( learnt through watching config as the parent) , made the asked changes and the preview also works fine , sorry for mistakenly closing the previous PR |
|
Please squash the commits |
AkihiroSuda
reviewed
Feb 15, 2025
| connect_to_vm_via{"Connect to the VM via"} -- "localhost" --> default["Default"] | ||
| connect_to_vm_via -- "IP" --> connect_from{"Connect to the VM IP from"} | ||
| connect_from -- "Host" --> vm{"VM type"} | ||
| vm -- "vz" --> vzNAT["vzNAT"] |
There was a problem hiding this comment.
Suggested change
| vm -- "vz" --> vzNAT["vzNAT"] | |
| vm -- "vz" --> vzNAT["vzNAT (see the VMNet page)"] |
or, the vzNAT page should be split from the VMNet page
AkihiroSuda
reviewed
Feb 15, 2025
|
|
||
|
|
||
|
|
||
|
|
AkihiroSuda
reviewed
Feb 15, 2025
| user-v2 network provides a user-mode networking similar to the [default user-mode network](#user-mode-network--1921685024-) and also provides support for `vm -> vm` communication. | ||
|
|
||
| To enable this network mode, define a network with `mode: user-v2` in networks.yaml | ||
| title: VMNet Networks |
There was a problem hiding this comment.
Suggested change
| title: VMNet Networks | |
| title: VMNet networks |
For consistency with the other pages
kairveeehh
force-pushed
the
master
branch
3 times, most recently
from
e0747c2 to
f561976
Compare
|
done the fixes |
|
https://deploy-preview-3239--lima-vm.netlify.app/docs/config/network/
|
AkihiroSuda
reviewed
Feb 15, 2025
| flowchart | ||
| connect_to_vm_via{"Connect to the VM via"} -- "localhost" --> default["Default"] | ||
| connect_to_vm_via -- "IP" --> connect_from{"Connect to the VM IP from"} | ||
| connect_from -- "Host" --> vm{"VM type"}+ vm -- "vz" --> vzNAT["vzNAT (see the VMNet page)"] |
There was a problem hiding this comment.
Copy-paste error in this line
kairveeehh
force-pushed
the
master
branch
2 times, most recently
from
b3bde01 to
bf93bb6
Compare
Signed-off-by: Kairvee Vaswani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves (#1815 ) , did the fixes .