use more of the default symfony cs fixer rules

liip · Jan 19, 2025 · 6754d42 · 6754d42
1 parent a69d991
commit 6754d42
Show file tree

Hide file tree

Showing 13 changed files with 104 additions and 108 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -38,10 +38,6 @@
             'static_lambda' => true,
             'ternary_to_null_coalescing' => true,
             'void_return' => true,
-            'new_with_parentheses' => false,
-            'php_unit_data_provider_static' => false,
-            'php_unit_data_provider_name' => false,
-            'php_unit_data_provider_return_type' => false,
 
             // Don't mark tests as @internal
             'php_unit_internal_class' => false,

diff --git a/tests/BuilderTest.php b/tests/BuilderTest.php
@@ -43,7 +43,7 @@ protected function setUp(): void
 
     public function testBuild(): void
     {
-        $c = new class() {
+        $c = new class {
             /**
              * @var Nested
              */

diff --git a/tests/Metadata/PropertyTypeTest.php b/tests/Metadata/PropertyTypeTest.php
@@ -17,7 +17,7 @@
  */
 class PropertyTypeTest extends TestCase
 {
-    public function provideMergeCases(): iterable
+    public static function provideMergeCases(): iterable
     {
         yield [
             new PropertyTypeUnknown(true),

diff --git a/tests/Metadata/VersionRangeTest.php b/tests/Metadata/VersionRangeTest.php
@@ -49,7 +49,7 @@ public function testWithUntil(): void
         $this->assertSame('2', $version->getUntil());
     }
 
-    public function provideIsIncludedCases(): iterable
+    public static function provideIsIncludedCases(): iterable
     {
         return [
             'null is lowest and highest' => [
@@ -93,7 +93,7 @@ public function testIsIncluded(VersionRange $versionRange, string $version, bool
         $this->assertSame($expected, $versionRange->isIncluded($version));
     }
 
-    public function provideAllowsLowerThanCases(): iterable
+    public static function provideAllowsLowerThanCases(): iterable
     {
         return [
             'same null' => [
@@ -137,7 +137,7 @@ public function testAllowsLowerThan(VersionRange $versionRange, VersionRange $ot
         $this->assertSame($lower, $versionRange->allowsLowerThan($other));
     }
 
-    public function provideAllowsHigherThanCases(): iterable
+    public static function provideAllowsHigherThanCases(): iterable
     {
         return [
             'same null' => [

diff --git a/tests/ModelParser/JMSParserTest81.php b/tests/ModelParser/JMSParserTest81.php
@@ -16,7 +16,7 @@ class JMSParserTest81 extends JMSParserTestCase
 {
     public function testReadOnlyProperty(): void
     {
-        $c = new class() {
+        $c = new class {
             /**
              * @JMS\ReadOnlyProperty()
              */
@@ -35,7 +35,7 @@ public function testReadOnlyProperty(): void
 
     public function testAttributes(): void
     {
-        $c = new class() {
+        $c = new class {
             #[JMS\Type('string')]
             private $property1;
 
@@ -62,7 +62,7 @@ public function testAttributes(): void
 
     public function testAttributesMixedWithAnnotations(): void
     {
-        $c = new class() {
+        $c = new class {
             /**
              * @JMS\SerializedName("property_mixed")
              *
@@ -106,7 +106,7 @@ public function testAttributesMixedWithAnnotations(): void
 
     public function testVirtualPropertyWithoutDocblock(): void
     {
-        $c = new class() {
+        $c = new class {
             #[JMS\VirtualProperty]
             public function foo(): string
             {