-
Notifications
You must be signed in to change notification settings - Fork 16
#79 Prevents lightchain node dir to be overwritten accidentally on init. #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EnchanterIO
commented
Feb 27, 2019
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
@@ -75,6 +76,13 @@ func newNodeCfgFromCmd(cmd *cobra.Command) (node.Config, setup.Network, error) { | |||
shouldTrace, _ := cmd.Flags().GetBool(TraceFlag.Name) | |||
traceLogFilePath, _ := cmd.Flags().GetString(TraceLogFlag.Name) | |||
|
|||
// This should be done inside of the `node.Init()` pkg but due to bad design, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to create an issue and include the number as part of this doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 802bf83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 802bf83
database/node.go
Outdated
@@ -34,6 +34,7 @@ func NewNode(cfg *Config, consensusAPI conAPI.API, registry *prometheus.Registry | |||
return nil, err | |||
} | |||
|
|||
// Todo: Should be refactored, creating a new instance of a struct SHOULDN'T do any FS changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment could be part of the issue added to the backlog refering to the pending refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 802bf83