#79 Prevents lightchain node dir to be overwritten accidentally on init. #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EnchanterIO
commented
Feb 27, 2019
EnchanterIO
commented
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
ggarri
approved these changes
Feb 27, 2019
| @@ -75,6 +76,13 @@ func newNodeCfgFromCmd(cmd *cobra.Command) (node.Config, setup.Network, error) { | |||
| shouldTrace, _ := cmd.Flags().GetBool(TraceFlag.Name) | |||
| traceLogFilePath, _ := cmd.Flags().GetString(TraceLogFlag.Name) | |||
|
|
|||
| // This should be done inside of the `node.Init()` pkg but due to bad design, | |||
There was a problem hiding this comment.
Would you mind to create an issue and include the number as part of this doc?
database/node.go
Outdated
| @@ -34,6 +34,7 @@ func NewNode(cfg *Config, consensusAPI conAPI.API, registry *prometheus.Registry | |||
| return nil, err | |||
| } | |||
|
|
|||
| // Todo: Should be refactored, creating a new instance of a struct SHOULDN'T do any FS changes | |||
There was a problem hiding this comment.
This comment could be part of the issue added to the backlog refering to the pending refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.